Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved proto deps into toolchain to avoid confusing boiler plate code #678

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Apr 7, 2021

Users looking to register their own toolchain sometimes stumble over the fact that every use of rust_grpc_library or rust_proto_library now requires them to also add the appropriate targets to the rust_deps attributes. This is easily missed and not necessary. Instead, these dependencies should be added to the @rules_rust//proto:toolchain being used so there's a single source of truth for all the dependencies required by these rules.

Additionally, this allows users to optionally not register the default toolchain in cases where they want to define their own but would like to ensure other dependencies are brought in.

closes #483

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@UebelAndre
Copy link
Collaborator Author

This is a reboot of #519

@google-cla
Copy link

google-cla bot commented Apr 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 7, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 7, 2021
@UebelAndre UebelAndre marked this pull request as ready for review April 7, 2021 22:47
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty reasonable :)

@UebelAndre UebelAndre merged commit 8bad4c5 into bazelbuild:main Apr 9, 2021
@UebelAndre UebelAndre deleted the proto branch April 9, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reintroduce proto_compile_deps and grpc_compile_deps to rust_proto_toolchain
2 participants