You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now in crate_universe we do hand-crafted string templating for the http_archive/git_repository rules, and then invoke tera for the build_file_contents.
We shouldn't be doing hand-crafted string templating. We should also have some unit tests for "this crate turns into this output", rather than only testing generation with integration tests.
I'll put together a patch :)
The text was updated successfully, but these errors were encountered:
Is there not more that can be lifted from cargo-raze::rendering? I feel like this functionality is all there. Also, #657 seems relevant to this as well.
Right now in crate_universe we do hand-crafted string templating for the http_archive/git_repository rules, and then invoke tera for the build_file_contents.
We shouldn't be doing hand-crafted string templating. We should also have some unit tests for "this crate turns into this output", rather than only testing generation with integration tests.
I'll put together a patch :)
The text was updated successfully, but these errors were encountered: