Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate_universe: Use tera for generating top-level repository rules #652

Closed
illicitonion opened this issue Mar 29, 2021 · 3 comments
Closed

Comments

@illicitonion
Copy link
Collaborator

Right now in crate_universe we do hand-crafted string templating for the http_archive/git_repository rules, and then invoke tera for the build_file_contents.

We shouldn't be doing hand-crafted string templating. We should also have some unit tests for "this crate turns into this output", rather than only testing generation with integration tests.

I'll put together a patch :)

@UebelAndre
Copy link
Collaborator

Is there not more that can be lifted from cargo-raze::rendering? I feel like this functionality is all there. Also, #657 seems relevant to this as well.

@illicitonion
Copy link
Collaborator Author

#655 covers all I'm thinking about doing for this issue :) very happy to re-use more of cargo-raze if we can, too

@illicitonion
Copy link
Collaborator Author

This got done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants