Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rules should test a min Rust version in CI #828

Closed
UebelAndre opened this issue Jul 10, 2021 · 0 comments · Fixed by #1720
Closed

The rules should test a min Rust version in CI #828

UebelAndre opened this issue Jul 10, 2021 · 0 comments · Fixed by #1720

Comments

@UebelAndre
Copy link
Collaborator

rules_rust has some Rust targets which are exposed to users, meaning, built using their toolchains. Commonly, the toolchains come from rust_repositories where users may explicitly set a rust version. eg:

rust_repositories(
    version = "1.53.0",
    edition = "2018",
)

The rules try to default version to the latest released version of Rust but in cases where users have pinned it, they may find themselves in a situation where they consume a new release of the rules but can no longer build due to a change in one of these exposed targets which brings in new functionality not in the pinned version or Rust.

To name a few exposed targets:

I think having a min-tested version of Rust for the rules would help catch these issues and should be built into the upcoming release model (#415).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant