Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI for minimum supported Rust version #1720

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 21, 2022

This change adds jobs to CI that test a minimum supported Rust version. This job is intended to inform contributors when a change is being made that would force users to upgrade their Rust version.

closes #828

@UebelAndre
Copy link
Collaborator Author

Rust Versiosn and associated repository errors

1.58.0

(17:15:55) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/cui__rustix-0.36.4/BUILD.bazel:27:13: Compiling Rust rlib rustix v0.36.4 (214 files) failed: (Exit 1): process_wrapper failed: error executing command (from target @cui__rustix-0.36.4//:rustix)
  (cd /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/1064/execroot/rules_rust && \
  exec env - \
    CARGO_CFG_TARGET_ARCH=x86_64 \
    CARGO_CFG_TARGET_OS=linux \
    CARGO_CRATE_NAME=rustix \
    CARGO_MANIFEST_DIR='${pwd}/external/cui__rustix-0.36.4' \
    CARGO_PKG_AUTHORS='' \
    CARGO_PKG_DESCRIPTION='' \
    CARGO_PKG_HOMEPAGE='' \
    CARGO_PKG_NAME=rustix \
    CARGO_PKG_VERSION=0.36.4 \
    CARGO_PKG_VERSION_MAJOR=0 \
    CARGO_PKG_VERSION_MINOR=36 \
    CARGO_PKG_VERSION_PATCH=4 \
    CARGO_PKG_VERSION_PRE='' \
    OUT_DIR='${pwd}/bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4/rustix_build_script.out_dir' \
    SYSROOT=bazel-out/k8-fastbuild/bin/external/rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools/rust_toolchain \
  bazel-out/k8-opt-exec-2B5CBBC6/bin/util/process_wrapper/process_wrapper --env-file bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4/rustix_build_script.env --arg-file bazel-out/k8-fastbuild/bin/external/cui__io-lifetimes-1.0.3/io-lifetimes_build_script.linksearchpaths --arg-file bazel-out/k8-fastbuild/bin/external/cui__libc-0.2.137/libc_build_script.linksearchpaths --arg-file bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4/rustix_build_script.linksearchpaths --arg-file bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4/rustix_build_script.flags --arg-file bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4/rustix_build_script.linkflags --subst 'pwd=${pwd}' -- bazel-out/k8-fastbuild/bin/external/rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools/rust_toolchain/bin/rustc external/cui__rustix-0.36.4/src/lib.rs '--crate-name=rustix' '--crate-type=rlib' '--error-format=human' '--codegen=metadata=-2586150994' '--codegen=extra-filename=-2586150994' '--out-dir=bazel-out/k8-fastbuild/bin/external/cui__rustix-0.36.4' '--codegen=opt-level=0' '--codegen=debuginfo=0' '--remap-path-prefix=${pwd}=' '--emit=dep-info,link' '--color=always' '--target=x86_64-unknown-linux-gnu' --cfg 'feature="default"' --cfg 'feature="io-lifetimes"' --cfg 'feature="libc"' --cfg 'feature="std"' --cfg 'feature="termios"' --cfg 'feature="use-libc-auxv"' -L bazel-out/k8-fastbuild/bin/external/rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools/rust_toolchain/lib/rustlib/x86_64-unknown-linux-gnu/lib '--cap-lints=allow' '--edition=2018' '--extern=bitflags=bazel-out/k8-fastbuild/bin/external/cui__bitflags-1.3.2/libbitflags-2379027655.rlib' '--extern=io_lifetimes=bazel-out/k8-fastbuild/bin/external/cui__io-lifetimes-1.0.3/libio_lifetimes-818953534.rlib' '--extern=libc=bazel-out/k8-fastbuild/bin/external/cui__libc-0.2.137/liblibc-3499670893.rlib' '--extern=linux_raw_sys=bazel-out/k8-fastbuild/bin/external/cui__linux-raw-sys-0.1.3/liblinux_raw_sys-2074836458.rlib' '-Ldependency=bazel-out/k8-fastbuild/bin/external/cui__bitflags-1.3.2' '-Ldependency=bazel-out/k8-fastbuild/bin/external/cui__libc-0.2.137' '-Ldependency=bazel-out/k8-fastbuild/bin/external/cui__io-lifetimes-1.0.3' '-Ldependency=bazel-out/k8-fastbuild/bin/external/cui__linux-raw-sys-0.1.3')
# Configuration: ed4ae5ad847fcbdaf993fa00757c44deec9db819739f2edc305790ffca6d10be
# Execution platform: @local_config_platform//:host
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
error: could not find native static library `rustix_outline_x86_64`, perhaps an -L flag is missing?
 
error: aborting due to previous error

platform: ubuntu2004
shell_commands: *min_rust_version_shell_commands
build_targets: *single_rust_channel_targets
test_targets: *single_rust_channel_targets
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think we should be testing the rules all together, there might be value in having more granular testing for this since the current failure on 1.58.0 is a failure in a transitive crate_universe dependency. Open to suggestions on how this should be structured.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scentini @krasimirgg any thoughts here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge for now. The jobs can be updated in a separate change.

@UebelAndre UebelAndre enabled auto-merge (squash) December 22, 2022 16:07
@UebelAndre UebelAndre merged commit 90c5b6e into bazelbuild:main Dec 22, 2022
@UebelAndre UebelAndre deleted the minrust branch December 22, 2022 16:13
@UebelAndre UebelAndre mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The rules should test a min Rust version in CI
2 participants