Avoid Win32 MAX_PATH issues by shortening cargo_build_script
bin names
#1006
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into issues on Windows where
cargo_build_script
targets are filing to find files. After an investigation, I've found the cause to be paths exceeding the Windows max path length limitation. This change would shorten the runfiles path, potentially keeping some runfiles paths within the 260 character capbefore:
after:
Understandably this doesn't solve for all issues since another target may exceed the character limit again, but every character counts and given that this hasn't been a huge issue, I suspect libnghttp2-sys might just be the extreme case (or we don't have many windows users).