Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ compilation warning #1011

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix C++ compilation warning #1011

merged 1 commit into from
Nov 12, 2021

Conversation

UebelAndre
Copy link
Collaborator

This fixes the following warning which I found when building on Linux

INFO: From Compiling util/process_wrapper/utils.cc:
external/rules_rust/util/process_wrapper/utils.cc: In function 'bool process_wrapper::ReadStampStatusToArray(const StrType&, std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > >&)':
external/rules_rust/util/process_wrapper/utils.cc:113:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Wsign-compare]
  113 |   for (int i = 0; i < stamp_block.size(); ++i) {
      |                   ~~^~~~~~~~~~~~~~~~~~~~

@UebelAndre UebelAndre merged commit 1fc2993 into bazelbuild:main Nov 12, 2021
@UebelAndre UebelAndre deleted the stamp-2 branch November 12, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants