Rustdoc rules now share a code path with Rustc rules for more consistency #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
rustdoc
branch
15 times, most recently
from
93af95c
to
142cc88
Compare
UebelAndre
force-pushed
the
rustdoc
branch
3 times, most recently
from
58f8d81
to
5b8cfdd
Compare
|
I was unfortunately not able to get a solution for #980 in this PR (which is a hard problem to solve, for me 😅). |
hlopko
reviewed
Nov 16, 2021
ddeville
pushed a commit
to ddeville/rules_rust
that referenced
this pull request
Nov 22, 2021
…ency (bazelbuild#1015) * Rustdoc rules now share a code path with Rustc rules for more consistency * Regenerate documentation * Addressed PR feedback * Addressed PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust_docThe first issue I faced with
rust_docwas #947 but quickly found there were many more variables being defined forRustcactions but notRustdoc, leading to my inability to use the rule. The changes here introduce a macro@rules_rust//rust/private:rustdoc.bzl%rustdoc_compile_actiondesigned to create a near identical action@rules_rust//rust/private:rustc.bzl&rustc_compile_actionfor improved consistency in generating docs to solve for the issues I ran into.rust_doc_testAdditionally, the
rust_doc_testwas similarly unusable due to the fact thatrustdoc --testbuilds and tests binaries as a test execution but the test environment was quite different from the build environments ofRustdocandRustcactions. This PR shares the samerustdoc_compile_actionfunctionality to determine action args, environment vars, and inputs and write an executable to rebuild an execution environment similar to the build actions.Notably, this fixes
rust_doc_testin RBE and Windows environments.Related Issues
closes #887
closes #947
closes #804
closes #1016