tools/runfiles: use $TEST_SRCDIR when available #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems good to me but wanna make sure we're not missing anything else while focus is on this section of the rules 😄. @TimNN Are you able to talk about the specifics of what doesn't work with the current implementation? I requested @hlopko join the review (as, to my knowledge, the only Googler actively maintaining these rules) in case there's some sensitive details here. |
|
I don't think the details are particularly sensitive. The issue is that the directory structure used by our CI system does not follow the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel sets the
$TEST_SRCDIRenvironment variable telling tests the "absolute path to the base of the runfiles tree", see the test encyclopedia.That should in general be the more reliable way to determine the runfiles directory (when available), I think, but the current logic also does not always work when running tests internally at Google.