Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add dylibs to runfiles of rlibs #1052

Merged
merged 10 commits into from
Dec 2, 2021
Merged

Don't add dylibs to runfiles of rlibs #1052

merged 10 commits into from
Dec 2, 2021

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented Dec 1, 2021

They are not needed, and flattening transitive_noncrates is expensive

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@scentini scentini marked this pull request as ready for review December 1, 2021 14:58
@scentini scentini requested a review from hlopko December 1, 2021 14:58
@scentini
Copy link
Collaborator Author

scentini commented Dec 2, 2021

We actually don't need to manually add dylibs to runfiles at all, as we create runfiles with collect_data = True.

@scentini scentini merged commit 65b558c into bazelbuild:main Dec 2, 2021
@scentini scentini deleted the runfiles-conditional branch December 2, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlopko hlopko hlopko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scentini @hlopko