Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of DepInfo.transitive_libs #1054

Merged
merged 14 commits into from
Dec 6, 2021

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented Dec 2, 2021

This is a step further towards #1051.

With this change, rules_rust doesn't need DepInfo.transitive_libs anymore. The only place where this field was used was to pass the files it contains as inputs to rust compile actions. We use DepInfo.transitive_crate_outputs for that now. For non-rlib compile actions, which need non-crate inputs as well, we add those inputs to the additional_transitive_inputs variable.

@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@scentini scentini marked this pull request as ready for review December 6, 2021 13:06
@scentini scentini requested a review from hlopko December 6, 2021 13:06
@scentini scentini merged commit 7ef755b into bazelbuild:main Dec 6, 2021
@scentini scentini deleted the deprecate-transitive-libs branch December 6, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants