Fix proc_macro_dylib_path when they are built in both opt and debug #1089
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
approved these changes
Jan 11, 2022
cfredric
pushed a commit
to cfredric/rules_rust
that referenced
this pull request
Feb 16, 2022
…azelbuild#1089) * Fix proc_macro_dylib_path in cases where they are built in both opt and debug * Resolve rustfmt issues * Update test comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For workspace members, a crate_spec is generated for both opt and debug configurations, but when a build is executed, proc-macros are built and used only in the opt configuration. This can result in rust-analyzer looking for the proc macro in the fastbuild location when it was only created in the opt location. Rust analyzer will then be unable to find and use the dylib and code generated by the proc-macro will not have annotations.
This PR fixes the issue by preferring the proc_macro_dylib_path with the
-opt-exec-path component when merging CrateSpecs.