Renamed rust_toolchain.rust_lib to rust_toolchain.rust_std
#1102
+69
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jan 24, 2022
hlopko
approved these changes
Jan 24, 2022
cfredric
pushed a commit
to cfredric/rules_rust
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel
rust_toolchain.rust_libis misleading. The expected content of the attribute is an extraction of a Rust standard library artifact (e.g. rust-std-1.58.1-x86_64-unknown-linux-gnu.tar.gz). This minor cleanup makes that more obvious by matching the naming convention of the artifact itself.Note that this change is still backwards compatible with
rust_toolchain.rust_libbut I think it should be deprecated after some time.