Added rules_rust_dependencies and rust_register_toolchains macros
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested changes
Jan 25, 2022
UebelAndre
changed the title
rules_rust_dependencies and rust_register_toolchains macros
hlopko
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Thank you! This is also conforming to https://docs.bazel.build/versions/main/skylark/deploying.html \o/ :)
luiz10x
reviewed
Jan 27, 2022
| @@ -127,12 +127,14 @@ PAGES = dict([ | |||
| page( | |||
| name = "rust_repositories", | |||
| symbols = [ | |||
| "rules_rust_depednencies", | |||
There was a problem hiding this comment.
Drive-by comment, but should it be rules_rust_dependencies here?
There was a problem hiding this comment.
Oops! Thanks! #1110
cfredric
pushed a commit
to cfredric/rules_rust
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to have more control over what repositories are created when setting up
rules_rustin their workspace and conforms to the bazel-contrib guide for Bazel rules.