Replaced CI flags with compatibility flags for incompatible targets #1107
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jan 27, 2022
cfredric
pushed a commit
to cfredric/rules_rust
that referenced
this pull request
Feb 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving to Bazel 4.0 as the min target, we can now use
target_compatible_withto filter incompatible targets. This allows the target definitions themselves to describe what they currently support and makes it easier for contributors to test changes as they don't need to worry about targets that are known to not work for the platform failing.The MacOS side of this can likely be removed in #921 but since that's been there for some time, I think it's fine to add the flag here.