Fix rust_doc_test using execpath paths instead of rootpath
#1129
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasimirgg
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Looks good!
Just to clarify, does this need to be submitted after #1119?
illicitonion
approved these changes
Feb 8, 2022
No, these changes are effectively a no-op since the execpath and rootpath of rustdoc is the same today. My thought in opening this was to reduce the size of that PR. |
That's where these changes would begin to take effect. Technically there's already coverage since there's already tests for rust_doc_test. I don't think additional testing is needed in this change. |
cfredric
pushed a commit
to cfredric/rules_rust
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was split from #1119 (comment)