Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced crates_universe rule with crates_repository #1158

Merged
merged 8 commits into from
Mar 3, 2022

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Feb 27, 2022

This PR replaces the existing crate_universe rules and binaries with https://github.com/abrisco/cargo-bazel which is an equivalent tool that generally solves for the same desires and is more self-contained.

@UebelAndre UebelAndre force-pushed the crate_universe branch 8 times, most recently from 68825c5 to 293e821 Compare March 1, 2022 00:30
@UebelAndre UebelAndre force-pushed the crate_universe branch 2 times, most recently from b401446 to ebe8ad5 Compare March 3, 2022 05:24
@UebelAndre UebelAndre marked this pull request as ready for review March 3, 2022 05:36
@UebelAndre
Copy link
Collaborator Author

@illicitonion would likely be the best reviewer since, to my knowledge, they're avid consumers of crates_universe.

I tried to refactor this PR into small sections to make this easier to review. Each commit should be reviewed individually and anything that refers to "Updating lockfiles" is a commit containing generated content and is probably not worth digging into after confirming the code changes are in a good state.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shikhar
Copy link
Contributor

shikhar commented Mar 3, 2022

Curious, what is the relationship between crates_universe and cargo-bazel? I see similar APIs, so looks like there is some shared history?

@illicitonion
Copy link
Collaborator

Curious, what is the relationship between crates_universe and cargo-bazel? I see similar APIs, so looks like there is some shared history?

My team and I put together crates_universe as an experimental prototype, and after a few folks including @UebelAndre started using it, @UebelAndre was inspired to rewrite it in a much cleaner way. They have some shared history, but cargo-bazel is a much more principled, well-thought-out implementation, learning from the lessons we learnt in crates_universe, rather than trying to do whatever expedient things we could in the original prototype to get something working fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants