Treat rustfmt as optional #1164
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested changes
Mar 3, 2022
illicitonion
force-pushed
the
optional-rustfmt
branch
from
c81a82e
to
a007ef5
Compare
UebelAndre
requested changes
Mar 3, 2022
illicitonion
force-pushed
the
optional-rustfmt
branch
2 times, most recently
from
231b372
to
085ba68
Compare
All the code above this call treats rustfmt as optional, but then when we make the BUILD for the rust toolchain, we unconditionally point at the presumed rustfmt label. At https://github.com/bazelbuild/rules_rust/blob/59fab4e79f62bfa13551ac851a40696c24c0c3a4/rust/toolchain.bzl#L331-L335 we conditionally create a symlink based on whether the attribute is set, but because we unconditionally set the attribute, this causes a hard error failing to symlink to a non-existent file. Instead, treat rustfmt as optional in this function too, so that the code above and below properly convey the optionality to each other.
illicitonion
force-pushed
the
optional-rustfmt
branch
from
085ba68
to
a1c0726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the code above this call treats rustfmt as optional, but then when
we make the BUILD for the rust toolchain, we unconditionally point at
the presumed rustfmt label.
At
rules_rust/rust/toolchain.bzl
Lines 331 to 335 in 59fab4e
we conditionally create a symlink based on whether the attribute is set,
but because we unconditionally set the attribute, this causes a hard
error failing to symlink to a non-existent file.
Instead, treat rustfmt as optional in this function too, so that the
code above and below properly convey the optionality to each other.