Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut loading time deps of the import macro #1177

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Cut loading time deps of the import macro #1177

merged 3 commits into from
Mar 8, 2022

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Mar 7, 2022

Fixes #1166.

@hlopko hlopko mentioned this pull request Mar 7, 2022
Closed
@wt
Copy link
Contributor

wt commented Mar 7, 2022

This does not fix #1166

@hlopko
Copy link
Member Author

hlopko commented Mar 8, 2022

(continuing on the issue: #1166 (comment))

illicitonion
illicitonion approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, and taught me about a whole new feature of Bazel I didn't know about - thanks so much!

UebelAndre
UebelAndre approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks!

@wt
Copy link
Contributor

wt commented Mar 8, 2022

Now that the main branch has been merged into your branch, this seems to fix the problem. When I reported that it wasn't fixed, your branch on github didn't include the merge of main.

@wt
Copy link
Contributor

wt commented Mar 8, 2022

I think I just managed to sync your branch before the merge was in there. Anyway, it does seem to work now.

@hlopko hlopko merged commit e5fefdc into bazelbuild:main Mar 8, 2022
@hlopko hlopko deleted the fix_import_macro_loading_time_deps branch March 8, 2022 21:12
@illicitonion illicitonion mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regressive commit
4 participants
@hlopko @wt @illicitonion @UebelAndre