Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test showing that rust_analayzer aspect traverses aliases #1188

Merged

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Mar 14, 2022

No description provided.

@hlopko hlopko requested a review from UebelAndre March 14, 2022 09:08
@hlopko
Copy link
Member Author

hlopko commented Mar 14, 2022

Apparently Bazel is handling aliases specially and does this for us for free.

@hlopko hlopko force-pushed the traverse_alias_with_rust_analyzer_aspect branch 2 times, most recently from 597348c to 0573fcd Compare March 14, 2022 10:18
@hlopko hlopko force-pushed the traverse_alias_with_rust_analyzer_aspect branch from 0573fcd to 0a685bb Compare March 14, 2022 10:22
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending #1189 (comment), this looks good to me. Thanks!

@hlopko hlopko force-pushed the traverse_alias_with_rust_analyzer_aspect branch from 0a685bb to a48a97f Compare March 15, 2022 08:11
@hlopko hlopko merged commit 4504983 into bazelbuild:main Mar 15, 2022
@hlopko hlopko deleted the traverse_alias_with_rust_analyzer_aspect branch March 18, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants