Traverse custom alias-like rules in the rust analyzer aspect #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Mar 14, 2022
rust/private/rust_analyzer.bzl
Outdated
| if BuildInfo in dep: | ||
| build_info = dep[BuildInfo] | ||
| dep_infos = [] | ||
| if hasattr(ctx.rule.attr, "proc_macro_deps"): |
There was a problem hiding this comment.
This feels worth a comment - I'm assuming this is for sniffing whether we're a rules_rust rule vs some other one, which happens to also expose BuildInfo?
There was a problem hiding this comment.
This was a bug :) I wanted to test if there is 'deps' attribute, not a 'proc_macro_deps' attribute. Fixed now.
| if hasattr(ctx.rule.attr, "proc_macro_deps"): | ||
| dep_infos += [dep[RustAnalyzerInfo] for dep in ctx.rule.attr.proc_macro_deps if RustAnalyzerInfo in dep] | ||
| if hasattr(ctx.rule.attr, "crate") and ctx.rule.attr.crate != None: | ||
| dep_infos.append(ctx.rule.attr.crate[RustAnalyzerInfo]) | ||
| if hasattr(ctx.rule.attr, "actual") and ctx.rule.attr.actual != None: | ||
| dep_infos.append(ctx.rule.attr.actual[RustAnalyzerInfo]) |
There was a problem hiding this comment.
This should probably sniff for whether actual has a RustAnalyzerInfo before trying to read it?
hlopko
force-pushed
the
traverse_custom_alias_like_rules_with_rust_analyzer_aspect
branch
from
aa83917
to
90f0c3d
Compare
illicitonion
approved these changes
Mar 15, 2022
hlopko
force-pushed
the
traverse_custom_alias_like_rules_with_rust_analyzer_aspect
branch
from
8aa19f5
to
166b4fa
Compare
hlopko
deleted the
traverse_custom_alias_like_rules_with_rust_analyzer_aspect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.