toolchain files: ensure test depends on std #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes intended. Among the standard rust libs, libtest depends on libstd: https://github.com/rust-lang/rust/blob/master/library/test/Cargo.toml#L12 The current implementation was adding it to `between_core_and_std_files`. This may cause backward reference linker errors in some configurations where the linker is configured to check for such backward references and the toolchain uses the static version of libtest.
UebelAndre
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes intended.
Among the standard rust libs, libtest depends on libstd:
https://github.com/rust-lang/rust/blob/master/library/test/Cargo.toml#L12
The current implementation was adding it to
between_core_and_std_files. This may cause backward reference linkererrors in some configurations where the linker is configured to check
for such backward references and the toolchain uses the static version
of libtest.