Merge runfiles from transitive dependencies of rust_test crate attr #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilisaac
commented
Jul 27, 2022
| @@ -1046,6 +1046,9 @@ def rustc_compile_action( | |||
| files = getattr(ctx.files, "data", []) + coverage_runfiles, | |||
| collect_data = True, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Do you want to attempt to remove it in this change? Or an isolated change?
There was a problem hiding this comment.
I'm not really sure I understand the implications of using "collect_data" here, so I left it alone.
scentini
reviewed
Aug 1, 2022
neilisaac
commented
Aug 14, 2022
| #[test] | ||
| fn test_greeting_from_txt_file() { | ||
| let welcome = Greeter::from_txt_file().unwrap(); | ||
| assert_eq!("Welcome Rust", welcome.greeting("Rust")); |
There was a problem hiding this comment.
backporting this commit (with the test only) to main, I see:
thread 'greeter::test::test_greeting_from_txt_file' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', test/rust/src/greeter.rs:93:48
|
Hey @neilisaac, this PR looks good to me, however looks like CI is complaining about |
|
@scentini checks passed! |
scentini
approved these changes
Oct 7, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #266
I'm open to input from maintainers on how to do this.