Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Rust 1.63.0 #1512

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Added Rust 1.63.0 #1512

merged 5 commits into from
Aug 15, 2022

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre enabled auto-merge (squash) August 12, 2022 16:20
illicitonion
illicitonion approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a surprising number of .rs files changed in this PR? But both set of changes LGTM!

@UebelAndre UebelAndre merged commit 8bfed1c into bazelbuild:main Aug 15, 2022
@UebelAndre UebelAndre deleted the rustup branch August 15, 2022 08:30
@kalcutter
Copy link
Contributor

Please make a new release with this change 🎉

@UebelAndre
Copy link
Collaborator Author

There's a surprising number of .rs files changed in this PR? But both set of changes LGTM!

Clippy! If ever I make a change like that that’s generally why. Clippy or Rustfmt will have some change that doesn’t like some code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@UebelAndre @kalcutter @illicitonion