Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in an example of crates_repository rule #1520

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Fix typo in an example of crates_repository rule #1520

merged 3 commits into from
Aug 18, 2022

Conversation

tetsuok
Copy link
Contributor

@tetsuok tetsuok commented Aug 17, 2022

This fixes a typo in an example of crates_repository rule.

illicitonion
illicitonion approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the fix!

Would it be possible for you to run ./docs/update_docs.sh and re-push to your branch? That will update the generated documentation (and fix CI). Thanks!

@tetsuok
Copy link
Contributor Author

tetsuok commented Aug 18, 2022

@illicitonion Sure, will do.

@tetsuok
Copy link
Contributor Author

tetsuok commented Aug 18, 2022

I needed to fix crate_universe/private/crates_repository.bzl rather than docs/crate_universe.md.

@illicitonion
Copy link
Collaborator

Thanks!

@illicitonion illicitonion merged commit 055abd4 into bazelbuild:main Aug 18, 2022
@tetsuok tetsuok deleted the fix-typo-in-create-universe branch August 18, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tetsuok @illicitonion