Test rustc flag and feature flags

[damienmg]

PR #151 broke some usage of those flags that make cargo raze build file not work any more.

This PR adds those 2 flag to a library so we notice those breakage. It allow the change for "rustc_flags" and fix the "features" argument.

As a consequence passing ["--arg value"] to rustc_flags no longer works but that's fine (it's a reasonable breaking change). One should either do ["--arg", "value"] or ["--arg=value"].

[damienmg]

/cc @mfarrugi fyi

[mfarrugi]

Ah, didn't think of it as a breaking change. LGTM.

What's WIP about this?

[damienmg]

For now I fixed the args for one and sent a PR on cargo-raze to fix it (it's a breaking change but one that make sense).

The crate_features is still broken, I am trying to figure out why.

[damienmg]

Ok the fix is there now :)

[acmcarther]

I can't tell from a glance, but I suspect you already know:

What happens if you try to use the --arg value syntax with this change? Does it fail in a way that is obvious, or does it barf with some incomprehensible error?

(LGTM % answer to Q)

[damienmg]

Side-note: this change does not introduce the incompatible change, it was introduced by #151. It just make it explicit that there is a breaking change.

The error I had was okish but could be better: error: Unrecognized option: 'cap-lints allow'

The only difficulty was that it was coming from cargo-raze generated BUILD files.

[acmcarther]

Yeah, I understand that the original issue came from #151. I was mostly just wondering if this was also a good time to make the user-facing error easier to understand. It doesn't seem to me that there will be another obvious opportunity unless someone files a bug.

Ultimate decision is up to you since you're the one that had to debug the original issue, so you're most familiar with how hard that is to do with the current output.

[damienmg]

If I were setting the flag myself in the BUILD file the error would have been easy to understand, I had to figure things out because the error came from generated BUILD file.

I don't think it is worth the added complexity to output another error message (that would be probably 2-3 lines of code)

[damienmg]

Can someone merge it? I don't have write access to this repository.

[acmcarther]

Done!

[damienmg]

Thanks!

…

On Fri, Nov 9, 2018 at 11:28 PM Alex McArther ***@***.***> wrote: Done! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#153 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjHf0xBgOOc9usW76bSjYYJoPjz10f_ks5utgGegaJpZM4YXa2Z> .