Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to wasm-bindgen v0.2.83 #1567

Merged
merged 2 commits into from
Sep 28, 2022
Merged

update to wasm-bindgen v0.2.83 #1567

merged 2 commits into from
Sep 28, 2022

Conversation

khumps
Copy link
Contributor

@khumps khumps commented Sep 28, 2022

@google-cla
Copy link

google-cla bot commented Sep 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit beb554e into bazelbuild:main Sep 28, 2022
@khumps
Copy link
Contributor Author

khumps commented Sep 28, 2022

@UebelAndre I haven't been able to find documentation for it, but is there a way to pin my usage of rules rust to wasm-bindgen v0.2.82 until this goes out in the next release? Currently running into

it looks like the Rust project used to create this wasm file was linked against
version of wasm-bindgen that uses a different bindgen format than this binary:

  rust wasm file schema version: 0.2.83
     this binary schema version: 0.2.82

on a new bazel repository

@UebelAndre
Copy link
Collaborator

You should be able to configure our own toolchain:
https://bazelbuild.github.io/rules_rust/rust_wasm_bindgen.html#rust_wasm_bindgen_toolchain

This way you can use your own version of wasm_bindgen backed by your existing pool of creates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants