Move crate_root_src to utils.bzl #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The honest motivation for this little refactoring is https://github.com/google/crubit. In build rules that don't yet work in the open-source yet we need to patch
rust.bzlwith a custom logic encapsulated in a function (the function collects extra dependencies from aspects). This function is called fromrust.bzl, and it needs to callcrate_root_src. To prevent aloadcycle I'm moving the function toutils.bzl. I understand that it would be much better to justify this PR with a working build rules in Crubit, but that's unfortunately not easily achievable yet.