Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass -p to mkdir to make sure we do not fails if bazel already created the output directory #159

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Pass -p to mkdir to make sure we do not fails if bazel already created the output directory #159

merged 2 commits into from
Nov 16, 2018

Conversation

damienmg
Copy link
Collaborator

mfarrugi
mfarrugi approved these changes Nov 16, 2018
View reviewed changes
Copy link
Collaborator

@mfarrugi mfarrugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a previous build creating the directory? Or is it something else?

It might be more correct to rm -rf {dir} && mkdir {dir}, as I'm not sure what repeated calls to tar do.

@damienmg
Copy link
Collaborator Author

If bazel is consistent it should be creating an empty. But I'll add the rm -fr to be certain

@mfarrugi
Copy link
Collaborator

lgtm. You have merge rights now, right?

@damienmg
Copy link
Collaborator Author

Yes I was waiting for the CI results with the new change :)

@damienmg damienmg merged commit a04407d into bazelbuild:master Nov 16, 2018
@damienmg damienmg deleted the fix-dir-exists branch November 19, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfarrugi mfarrugi mfarrugi approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rules_rust is failing on ubuntu 14.04
3 participants
@damienmg @mfarrugi @googlebot