Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CI breakage #1619

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Fixed CI breakage #1619

merged 2 commits into from
Nov 2, 2022

Conversation

UebelAndre
Copy link
Collaborator

closes #1618

@UebelAndre
Copy link
Collaborator Author

For reviewers, the first commit contains the fix, the second is just regenerating outputs.

illicitonion
illicitonion reviewed Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I think you want to remove the >=s in all of these version constraints.

0.14.22 means >=0.14.22, <1
>=0.14.22 means >=0.14.22 which would allow selecting 1.0.0 if it were released.

I think you want the former?

@UebelAndre UebelAndre merged commit 81eaccf into bazelbuild:main Nov 2, 2022
@UebelAndre UebelAndre deleted the ci branch November 2, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion left review comments

@scentini scentini scentini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel CI: rules_rust is broken in Bazel@HEAD downstream
3 participants
@UebelAndre @illicitonion @scentini