Deduplicate expand_location targets in rust-project.json crate creation to avoid a bazel crash #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googleson78
force-pushed
the
gl/ra-deduplicate-expand-targets-upstream
branch
from
c018b0f
to
898d129
Compare
|
LGTM - if you merge/rebase master, we can merge this one, thanks! |
There's a bug in bazel where the server crashes if it encounters duplicate entries in expand_location's targets field. See bazelbuild/bazel#16664
googleson78
force-pushed
the
gl/ra-deduplicate-expand-targets-upstream
branch
from
898d129
to
da4c87c
Compare
|
Actually, there are a few other places where this potentially might be an issue - I'll try to catch all of them. |
It's actually more specific than the general ctx.expand_location
|
Took a shot - feel free to merge if you're happy with this. |
googleson78
force-pushed
the
gl/ra-deduplicate-expand-targets-upstream
branch
from
220ea53
to
bb50677
Compare
googleson78
force-pushed
the
gl/ra-deduplicate-expand-targets-upstream
branch
from
bb50677
to
af4e694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in bazel where the server crashes if it encounters duplicate entries in expand_location's targets field.
See bazelbuild/bazel#16664.