Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable windows job #1658

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Reenable windows job #1658

merged 2 commits into from
Nov 16, 2022

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented Nov 16, 2022 •
edited
Loading

Previously we were not passing --enable_runfiles to the CI tests. This PR fixes all the windows jobs to pass --enable_runfiles

@scentini scentini marked this pull request as ready for review November 16, 2022 12:34
@scentini scentini linked an issue Nov 16, 2022 that may be closed by this pull request
Bazel CI: rules_rust is failing on windows in Bazel@HEAD downstream #1629
Closed
@scentini scentini mentioned this pull request Nov 16, 2022
Closed
krasimirgg
krasimirgg approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@krasimirgg krasimirgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scentini scentini merged commit ff4e905 into bazelbuild:main Nov 16, 2022
@scentini scentini deleted the reenable_windows_job branch November 16, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasimirgg krasimirgg krasimirgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel CI: rules_rust is failing on windows in Bazel@HEAD downstream
2 participants
@scentini @krasimirgg