Add edition support to rules and toolchain. (#157) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfarrugi
commented
Dec 8, 2018
| @@ -9,6 +9,7 @@ load( | |||
|
|
|||
| rust_binary( | |||
| name = "hello_runfiles", | |||
| edition = "2018", | |||
There was a problem hiding this comment.
My plan is to use default_edition = "2018", and use edition = "2015" for stragglers.
mfarrugi
commented
Dec 8, 2018
rust/private/rust.bzl
Outdated
| @@ -183,6 +183,9 @@ _rust_common_attrs = { | |||
| ), | |||
| "deps": attr.label_list(), | |||
| "crate_features": attr.string_list(), | |||
| "edition": attr.string( | |||
| doc = "The rust edition to use for this crate.", | |||
There was a problem hiding this comment.
This is apparently the way forward, added note in #140
|
Ah forgot, need to update rustc to 1.31 in this repo.. will get to that a little later. |
mfarrugi
force-pushed
the
marco-edition-support
branch
from
643a1c8
to
054a478
Compare
acmcarther
reviewed
Dec 10, 2018
mfarrugi
force-pushed
the
marco-edition-support
branch
from
054a478
to
a7ddf39
Compare
|
Should be good now, lmk. |
acmcarther
reviewed
Dec 11, 2018
| link_search_flags += ["-Ldependency={}".format(dirname(c.output.short_path)) for c in d.transitive_crates.to_list()] | ||
|
|
||
| link_flags += ["-ldylib=" + get_lib_name(lib) for lib in d.transitive_dylibs.to_list()] | ||
| link_search_flags += ["-Lnative={}".format(dirname(lib.short_path)) for lib in d.transitive_dylibs.to_list()] | ||
| link_flags += ["-lstatic=" + get_lib_name(lib) for lib in d.transitive_staticlibs.to_list()] | ||
| link_search_flags += ["-Lnative={}".format(dirname(lib.short_path)) for lib in d.transitive_staticlibs.to_list()] | ||
|
|
||
| edition_flags = ["--edition={}".format(crate.edition)] if crate.edition != "2015" else [] |
There was a problem hiding this comment.
Really minor nit: Can this be converted to use the add_addition_flag fn?
There was a problem hiding this comment.
I couldn't think of a way to get the fn to work on both 'args' and 'list
i'll take a look at the rustdoc_test todo to use args
There was a problem hiding this comment.
filed bazelbuild/bazel#6888 for args issue
acmcarther
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly simple change, backwards compatible through optional/default parameters.
rust_toolchain.default_editionis not practically useful until cargo-raze is providing edition.