-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More bazel --incompatible fixes (#161) #169
Conversation
) | ||
|
||
output_dir = ctx.actions.declare_directory(ctx.label.name) | ||
args = ctx.actions.args() | ||
args.add(crate.root.path) | ||
args.add("--crate-name", crate.name) | ||
args.add("--output", output_dir) | ||
args.add("--output", output_dir.path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a separate breakage
@@ -2,9 +2,6 @@ | |||
The rust_toolchain rule definition and implementation. | |||
""" | |||
|
|||
def _get_files(labels): | |||
return [f for l in labels for f in getattr(l, "files", [])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear why this needed --incompatible_depset_is_not_iterable=false
to work, but I refactored it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This gets us from
to
Remaining issues:
Does it make sense that there are errors in
@bazel_tools
?