Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv32imc and riscv64gc to the known sha targets #1698

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

ted-logan
Copy link
Contributor

Add the representative riscv32imc and riscv64gc targets to the list of known targets to populate the known shas list:

  • riscv32imc-unknown-none-elf
  • riscv64gc-unknown-none-elf

Run //util:fetch_shas to update the known shas list. This adds the rust-std archive hashes for these targets for the supported stable, beta, and nightly releases to the FILE_KEY_TO_SHA dict so these hashes will be available to load_arbitrary_tool() to allow Bazel to cache the downloaded archives.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre
Copy link
Collaborator

I think you need to amend the last commit to bump CI

Add the representative riscv32imc and riscv64gc targets to the list of
known targets to populate the known shas list:

- riscv32imc-unknown-none-elf
- riscv64gc-unknown-none-elf

Run `//util:fetch_shas` to update the known shas list. This adds the
rust-std archive hashes for these targets for the supported stable,
beta, and nightly releases to the `FILE_KEY_TO_SHA` dict so these hashes
will be available to `load_arbitrary_tool()` to allow Bazel to cache the
downloaded archives.

Amended commit to bump CI.
@ted-logan
Copy link
Contributor Author

Thanks for the review! I bumped the commit (and then rebased to head), and CI ran and passed.

@UebelAndre UebelAndre merged commit 5826a50 into bazelbuild:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants