Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach debug info outputs to rust tests #1703

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

chancila
Copy link
Contributor

@chancila chancila commented Dec 16, 2022

Unclear why #1072 explicitly didn't allow tests to generate dsym files via the dsym_folder output group.

This change allows them to do so and make debugging easier on macos.

Manual verification on macos:

bazel build -c dbg //test/unit/debug_info:myrusttest
rust-lldb bazel-bin/test/unit/debug_info/test-2282882243/myrusttest \
    --one-line "image list" \
    --one-line "exit" | \
    grep DWARF &>/dev/null && echo "dSYM module loaded"

should print dSYM module loaded

@google-cla
Copy link

google-cla bot commented Dec 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chancila chancila force-pushed the ch/dsym_for_test branch 3 times, most recently from 8223043 to 5b3e027 Compare December 16, 2022 02:11
@chancila chancila changed the title Generate dSYM for rust_test Attach dSYM to dsym_folder output group for rust_test Dec 16, 2022
@chancila chancila changed the title Attach dSYM to dsym_folder output group for rust_test Attach debug info outputs to rust tests Dec 16, 2022
@illicitonion
Copy link
Collaborator

LGTM, thanks!

@ddeville I think you added this originally - was there an important reason to skip debug generation for tests?

@illicitonion illicitonion merged commit 8bc9f78 into bazelbuild:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants