crate_universe re-pinning now defaults to "workspace" #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
crate_universe
branch
from
6a1e56d
to
501b50a
Compare
UebelAndre
commented
Dec 22, 2022
| @@ -100,11 +100,11 @@ impl FromStr for CargoUpdateRequest { | |||
| fn from_str(s: &str) -> Result<Self, Self::Err> { | |||
| let lower = s.to_lowercase(); | |||
|
|
|||
| if ["1", "yes", "true", "on"].contains(&lower.as_str()) { | |||
| if ["eager", "full", "all"].contains(&lower.as_str()) { | |||
There was a problem hiding this comment.
Open to naming suggestions 😄
UebelAndre
force-pushed
the
crate_universe
branch
from
501b50a
to
43e6098
Compare
illicitonion
approved these changes
Jan 3, 2023
UebelAndre
force-pushed
the
crate_universe
branch
2 times, most recently
from
550cd15
to
d085908
Compare
UebelAndre
force-pushed
the
crate_universe
branch
from
d085908
to
2b085fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the default behavior of re-pinning with
crates_vendorandcrates_repositoryto re-pin workspace dependencies, not all transitive ones. Users who wish to do a full re-pin of all their dependencies should can pass the following values:eagerfullallcloses #1522