Don't propagate compatible_with to the underlying cargo_build_script rust_binary target
#1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the description, do you mean |
scentini
changed the title
compatible_with to the underlying cargo_build_script cc_binary targetcompatible_with to the underlying cargo_build_script rust_binary target
|
@UebelAndre Indeed, thanks! |
UebelAndre
approved these changes
Jan 5, 2023
krasimirgg
requested changes
Jan 5, 2023
krasimirgg
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly fixed the interaction between
compatible_withandcargo_build_scriptin #1745, however I forgot to remove thecompatible_withattribute from the underlyingrust_binarytarget. This target shouldn't have thecompatible_withspecification as we only depend on it inexecmode.