Fix typo: plced -> placed #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thb-sb
added a commit
to thb-sb/rules_rust
that referenced
this pull request
Apr 18, 2024
…ariables on darwin. This PR attempts to fix an issue with bindgen when used on darwin with clang compiled from source (i.e. from `@llvm-project`). When using clang compiled from source on darwin, libclang (used through `clang-sys`) failed to find system header files (such as `stdarg.h` or `stdbool.h`) because these files are actually living under the SDK path (under `<SDK_PATH>/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/` and `<SDK_PATH>/usr/include`). Similar to what Bazel did in their [`xcrunwrapper.sh`](https://github.com/bazelbuild/bazel/blob/d8c27bfcd37a74dfbf1bdb9a1e3df13af8360a01/tools/objc/xcrunwrapper.sh#L17), we must have a way to tell bindgen's libclang where to find these system headers. In this commit, I add the following two substitutes variables: - `${SDKROOT}`: replaced by `std::env::var("SDKROOT")` if found. - `${DEVELOPER_DIR}`: replaced by `std::env::var("DEVELOPER")` if found. This is similar to what it is currently done for `${pwd}`. The following rule should now work on darwin: ```c // mylib.h #include <stdarg.h> ``` ```starlark # BUILD cc_library( name = "mylib", srcs = ["mylib.c"], hdrs = ["mylib.h"], ) rust_bindgen_library( name = "mylib_bindgen", cc_lib = ":mylib", clang_flags = select({ "@platforms//os:macos": [ "--sysroot=${SDKROOT}", "-isystem${SDKROOT}/usr/include", "-isystem${SDKROOT}/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/", ], "//conditions:default": [], }), crate_name = "mylib", header = "mylib.h", ) ``` It may also fix bazelbuild#1834.
thb-sb
added a commit
to thb-sb/rules_rust
that referenced
this pull request
Apr 18, 2024
…ariables on darwin. This PR attempts to fix an issue with bindgen when used on darwin with clang compiled from source (i.e. from `@llvm-project`). When using clang compiled from source on darwin, libclang (used through `clang-sys`) failed to find system header files (such as `stdarg.h` or `stdbool.h`) because these files are actually living under the SDK path (under `<SDK_PATH>/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/` and `<SDK_PATH>/usr/include`). Similar to what Bazel did in their [`xcrunwrapper.sh`](https://github.com/bazelbuild/bazel/blob/d8c27bfcd37a74dfbf1bdb9a1e3df13af8360a01/tools/objc/xcrunwrapper.sh#L17), we must have a way to tell bindgen's libclang where to find these system headers. In this commit, I add the following two substitutes variables: - `${SDKROOT}`: replaced by `std::env::var("SDKROOT")` if found. - `${DEVELOPER_DIR}`: replaced by `std::env::var("DEVELOPER")` if found. This is similar to what it is currently done for `${pwd}`. The following rule should now work on darwin: ```c // mylib.h #include <stdarg.h> ``` ```starlark # BUILD cc_library( name = "mylib", srcs = ["mylib.c"], hdrs = ["mylib.h"], ) rust_bindgen_library( name = "mylib_bindgen", cc_lib = ":mylib", clang_flags = select({ "@platforms//os:macos": [ "--sysroot=${SDKROOT}", "-isystem${SDKROOT}/usr/include", "-isystem${SDKROOT}/System/Library/Frameworks/Kernel.framework/Versions/A/Headers/", ], "//conditions:default": [], }), crate_name = "mylib", header = "mylib.h", ) ``` It may also fix bazelbuild#1834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.