Fix helloworld_test to work on hosts without IPv6 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saw this in the logs after we migrated to run all CI jobs in Docker containers:
```
Started server on port 34711
thread 'test_client_server' panicked at ''message: "Hello world"' not found in 'Err(Http(ClientDied(Some(IoError(Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" })))))
'', external/examples/proto/helloworld/helloworld_test.rs:112:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
```
(from https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/9488b198-a478-4957-b975-e73ac35e3108/xamples/proto/helloworld/helloworld_test/attempt_1.log)
|
Mhm. My Rust is a bit rusty, it looks like it might be easier to just enable IPv6 support on the Docker hosts. 😅 |
|
Switched to host networking, which gives us a working ::1, so the test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this in the logs after we migrated to run all CI jobs in Docker containers:
(from https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/9488b198-a478-4957-b975-e73ac35e3108/xamples/proto/helloworld/helloworld_test/attempt_1.log)