-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have rustdoc return its output directory instead of zip default. #1868
Conversation
@scentini @krasimirgg would either of you be able to find out what's going on with the windows environment here? My changes here shouldn't impact these examples at all. |
Sorry for the delay @UebelAndre , I've been quite swamped with other work recently. I'll try to take a look at the failure tomorrow. |
I tried to reproduce today, but I couldn't get past some crate_universe error:
@UebelAndre do you have some pointers here?
I also reran your CI and currently it's the Zig task that's failing (I guess we could disable that one for now as it wasn't fixed for a few days now?). I will keep looking into the Windows flake though, I noticed quite a few similar failures recently. |
This is a breaking change for direct consumers of the
rust_doc
targets but fortunately the fix would be to simply consume the.zip
target with the same name. The benefit to this change though is zips are not created by default which saves time.