Take 'default_edition' as an optional parameter of BUILD_for_rust_toolchain. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmcarther
approved these changes
Feb 3, 2019
|
Yeah, and the argument is optional for the same reason.
For existing users, this would be a huge pain if they aren't using the
latest raze.. but I agree this would go on the list of breaking changes to
make before a 1.0 release.
…On Sun, Feb 3, 2019 at 6:18 PM Alex McArther ***@***.***> wrote:
***@***.**** approved this pull request.
Is this being set to "2015" for backwards compatibility?
I expect users would assume "2018" if they're using a modern toolchain.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#188 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLjePuAtDMHP-ZFJiATvhsMQWyET5tDks5vJ24wgaJpZM4agVkn>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this was missing when I went to use it..