Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of io_bazel #195

Closed
wants to merge 1 commit into from
Closed

Conversation

cushon
Copy link

@cushon cushon commented Feb 19, 2019

Copy link
Collaborator

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Liam,

I'd like to understand a bit more where it is coming from:

$ bazel query 'somepath(@io_bazel//tools/jdk:include/jni.h, //...)'
INFO: Invocation ID: 192a60e5-33c0-45f4-8472-3dc6c8d7712c
DEBUG: Rule 'io_bazel_skydoc' modified arguments {"shallow_since": "1544648677 +0100"}
DEBUG: Rule 'io_bazel_rules_sass' modified arguments {"shallow_since": "1542966119 +0100"}
DEBUG: Rule 'io_bazel' modified arguments {"shallow_since": "1543255285 -0800"}
INFO: Empty results
Loading: 0 packages loaded

io_bazel is not defined here, so there is probably something that is adding io_bazel as a repository somewhere in the transitive import.

Digging a bit into it.

@damienmg
Copy link
Collaborator

Hi Liam,

I'd like to understand a bit more where it is coming from:

$ bazel query 'somepath(@io_bazel//tools/jdk:include/jni.h, //...)'
INFO: Invocation ID: 192a60e5-33c0-45f4-8472-3dc6c8d7712c
DEBUG: Rule 'io_bazel_skydoc' modified arguments {"shallow_since": "1544648677 +0100"}
DEBUG: Rule 'io_bazel_rules_sass' modified arguments {"shallow_since": "1542966119 +0100"}
DEBUG: Rule 'io_bazel' modified arguments {"shallow_since": "1543255285 -0800"}
INFO: Empty results
Loading: 0 packages loaded

io_bazel is not defined here, so there is probably something that is adding io_bazel as a repository somewhere in the transitive import.

Digging a bit into it.

$ bazel query 'somepath(@docs//..., @io_bazel//tools/jdk:jni_header)'
INFO: Invocation ID: 0c3917d2-dc84-4481-bb3d-1b988c9ac4fc
DEBUG: Rule 'io_bazel_skydoc' modified arguments {"shallow_since": "1544648677 +0100"}
DEBUG: Rule 'io_bazel' modified arguments {"shallow_since": "1543255285 -0800"}
DEBUG: Rule 'io_bazel_rules_sass' modified arguments {"shallow_since": "1542966119 +0100"}
@docs//:rust-docs
@io_bazel//src/main/java/com/google/devtools/build/skydoc:skydoc
@io_bazel//src/main/java/com/google/devtools/build/skydoc:skydoc_lib
@io_bazel//src/main/java/com/google/devtools/build/skydoc/fakebuildapi/cpp:cpp
@io_bazel//src/main/java/com/google/devtools/build/lib/actions:actions
@io_bazel//src/main/java/com/google/devtools/build/lib:unix
@io_bazel//src/main/native:libunix.so
@io_bazel//src/main/native:jni.h
@io_bazel//src/main/native:copy_link_jni_header
@io_bazel//tools/jdk:jni_header
Loading: 56 packages loaded

I got it. This needs to be fixed on skydoc side. Maybe we should just switch to stardoc right now?

@damienmg
Copy link
Collaborator

Ok so I took a longer look and we should probably just update skydoc to a later version, bazelbuild/skydoc@7dccadb#diff-298c08b112de7c7b76694d16435c15a2 is probably the fix on skydoc side.

@damienmg
Copy link
Collaborator

I send #196 to update stardoc, I think this should fix the issue as stardoc is green itself.

@cushon cushon closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants