Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong checksum in doc #1964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wrong checksum in doc #1964

wants to merge 1 commit into from

Conversation

s50600822
Copy link 

shasum -a 256  rules_rust-v0.16.1.tar.gz
aaaa4b9591a5dad8d8907ae2dbe6e0eb49e6314946ce4c7149241648e56a1277  rules_rust-v0.16.1.tar.gz

UebelAndre
UebelAndre requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question

docs/index.md
@@ -22,7 +22,7 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# https://github.com/bazelbuild/rules_rust/releases
http_archive(
name = "rules_rust",
sha256 = "37f40490169dc94013c7566c75c861977a2c02ce5505b7e975da0f7d5f2231c8",
sha256 = "aaaa4b9591a5dad8d8907ae2dbe6e0eb49e6314946ce4c7149241648e56a1277",
urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.16.1/rules_rust-v0.16.1.tar.gz"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just update to 0.21.1?

Copy link
Author

@s50600822 s50600822 May 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few versions apart it may take more than just the file and the hash. Also, I was checking if this actually is the source of https://bazelbuild.github.io/rules_rust the page's metadata seems to have more than what this markdown file contains.

The metadata itself hardcoded pages with nonsecured "http" for metadata that Google uses,
Screenshot 2023-05-10 at 4 23 20 am

as a result, searching for bazel rust rule would bing up the doc page in unsecured link:

Screenshot 2023-05-10 at 3 38 03 am

and for some reason clicking on it land on unsecured page(github doesn't bother to redirect it to HTTPS for some reason):

Screenshot 2023-05-10 at 4 23 38 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s50600822 @UebelAndre