Fix build failure finding crate_roots when mixed with generated sources #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jul 5, 2023
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
Silcet
pushed a commit
to Silcet/rules_rust
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust_testtargets which providesrcsand mix generated files with source files in a sub directory will run into a rustc error where the detectedlib.rscould not be found for the build action. This is caused by all the sources being symlinked intobazel-outand the crate root detection logic being run on the direct sources and not the symlinks. The new test demonstrates this pattern is now supported.