Fix failure to build without iterable depset #221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue raised in #218.
Depsets are not backed by hash sets do not have a trivial check for existence. Thus we need to explicitly flatten the depset into a list of headers before we see if the header is in the set.
I'm not clear enough on how bindgen works to propose a more elegant fix. Doing this check at all requires flattening to a list, and I don't know how/if we could avoid doing this check.