Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky build and test failures on windows #2217

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix flaky build and test failures on windows #2217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cdc82e2
Patch github.com/bazelbuild/rules_rust/pull/1899
Oct 26, 2023
9a6959c
Shorten test names
Oct 26, 2023
19a727f
Uncomment unix os verification
Oct 26, 2023
1d39942
Revert "Shorten test names"
Oct 27, 2023
b7ee2a4
Shorten output root for windows build
Oct 27, 2023
21195f0
Revert "Shorten output root for windows build"
Oct 27, 2023
90d5423
Reapply "Shorten test names"
Oct 27, 2023
550a115
Disable proto targets on windows
Oct 27, 2023
7da2ab9
Revert "Reapply "Shorten test names""
Oct 27, 2023
c791b63
Reapply "Reapply "Shorten test names""
Oct 27, 2023
94b8be0
Revert "Patch github.com/bazelbuild/rules_rust/pull/1899"
Oct 27, 2023
4cc7176
Merge branch 'main' into fix-test-names
Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ default_macos_targets: &default_macos_targets
default_windows_targets: &default_windows_targets
- "--" # Allows negative patterns; hack for https://github.com/bazelbuild/continuous-integration/pull/245
- "//..."
- "-//test/proto/..."
- "-//test/unit/pipelined_compilation/..."
# The proto rules do not work on windows
- "-//proto/..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead tag specific targets as incompatible with windows? How many targets fail on windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much all proto targets fail on windows because rust_prost_toolchain fails building on windows after #1899 introduces a transition to make the filepath even longer with the config hash.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UebelAndre could we move this forward and disable windows the path length issues are taken care of?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not convinced we need to disable the unit tests but haven’t had time to figure out if transitioning for the panic PR is necessary.

- "-//test/proto/..."
crate_universe_vendor_example_targets: &crate_universe_vendor_example_targets
- "//vendor_external:crates_vendor"
- "//vendor_local_manifests:crates_vendor"
Expand Down
2 changes: 1 addition & 1 deletion test/rust_test_suite/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ rust_library(
)

rust_test_suite(
name = "tests_suite",
name = "suite",
srcs = glob(["tests/**"]),
edition = "2018",
deps = [":math_lib"],
Expand Down