Add allow_empty to glob, as the patterns don't necessarily match something #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thing This is needed for the change in Bazel --incompatible_disallow_empty_glob
laurentlb
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
This provides additional Bazel compatibility fixes (--incompatible_restrict_string_escapes)
damienmg
requested changes
Aug 6, 2019
| "lib/rustlib/{target_triple}/lib/*{dylib_ext}", | ||
| "lib/rustlib/{target_triple}/lib/*{staticlib_ext}", | ||
| ], | ||
| allow_empty = True, |
There was a problem hiding this comment.
In which case does that glob is empty? Can a comment be added to justify it?
There was a problem hiding this comment.
That's the error message I got:
glob pattern 'lib/rustlib/x86_64-unknown-linux-gnu/lib/*.a' didn't match anything, but allow_empty is set to False.
I don't know if it happens in other cases too.
There was a problem hiding this comment.
That seems to indicate a potential bug, this is expected that there is no .a file here. I guess the empty glob is acting if any of those is empty.
Can you just add a comment with the pattern that fails to justify this allow_empty? It's not important to fix at the moment but keeping track of why we did that is useful.
damienmg
approved these changes
Aug 6, 2019
| "lib/rustlib/{target_triple}/lib/*{dylib_ext}", | ||
| "lib/rustlib/{target_triple}/lib/*{staticlib_ext}", | ||
| ], | ||
| allow_empty = True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the change in Bazel --incompatible_disallow_empty_glob