Use C++ environment variables when constructing link command line #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
pushed a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Sep 26, 2019
Rules rust until the bug fix in bazelbuild/rules_rust#252 is submitted
|
Hmm, I see the same failure from my presubmits on master, but buildkite is green.. Something funky is going on? |
This PR makes sure that rustc action also takes declared environment variables from the C++ toolchain when constructing the action. This way the C++ toolchain can start using more environment variables without breaking rust.
hlopko
force-pushed
the
use_env_vars_from_cc_too
branch
from
e49efb8
to
cea36ae
Compare
|
Ok, I was using old fork, all is fine now, please take a look. |
mfarrugi
approved these changes
Sep 26, 2019
acmcarther
approved these changes
Sep 26, 2019
fweikert
added a commit
to bazelbuild/bazel-federation
that referenced
this pull request
Sep 27, 2019
We need to use a version of rules_rust that includes bazelbuild/rules_rust#252 in order to fix a breakage in the federation tests (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1209#df505afb-20a4-4056-ad06-2fa973dbc6c9).
fweikert
added a commit
to bazelbuild/bazel-federation
that referenced
this pull request
Sep 27, 2019
We need to use a version of rules_rust that includes bazelbuild/rules_rust#252 in order to fix a breakage in the federation tests (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1209#df505afb-20a4-4056-ad06-2fa973dbc6c9).
hlopko
pushed a commit
to bazelbuild/rules_docker
that referenced
this pull request
Sep 30, 2019
This version contains a fix (bazelbuild/rules_rust#252) for how rules_rust constructed C++ command lines.
hlopko
pushed a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Sep 30, 2019
bazelbuild/rules_rust#252 was merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that rustc action also takes declared environment
variables from the C++ toolchain when constructing the action. This way
the C++ toolchain can start using more environment variables without
breaking rust.