Update setup instructions #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The commit hash was not compatible with recent versions of Bazel - Update the dependency on skylib - Add the load statement for `http_archive`, for easier copy-pasting - Add an example of use (users shouldn't have to guess the load label) - Update the version requirement (0.25.0 can't build the code)
laurentlb
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
damienmg
reviewed
Oct 7, 2019
README.md
Outdated
Comment on lines
68
to
79
| ## Example | ||
|
|
||
| Here's an example to build a Hello World: | ||
|
|
||
| ```python | ||
| load("@io_bazel_rules_rust//rust:rust.bzl", "rust_binary") | ||
|
|
||
| rust_binary( | ||
| name = "rs", | ||
| srcs = ["hello.rs"], | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
I am doubtful this is useful. There is link for specific rules that have individual examples that are more explanatory.
There was a problem hiding this comment.
Removed.
When I tried the rule, I didn't find the label to load in the documentation. But now, I see it in the examples.
|
Except the example the change LGTM. Maybe we could have the documentation discussion in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_archive, for easier copy-pasting