fix: add all_files to the dummy cc_toolchain #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a problem where rustc_compile_action() tries to use the
`all_files` property of the cc_toolchain.
This problem only occurs after turning on the following Bazel flag:
--incompatible_enable_cc_toolchain_resolution
qzmfranklin
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
|
@johnedmonds Since you were the author of the rust-bazel-wasm support, I thought you might also want to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a problem where rustc_compile_action() tries to use the
all_filesproperty of the cc_toolchain.This problem only occurs after turning on the following Bazel flag:
--incompatible_enable_cc_toolchain_resolution
The dummy cc toolchain is only used for building for wasm32.